On Fri, 7 Aug 2026 20:50:20 GMT, Chen Liang <[email protected]> wrote:
>> I think `parsing_locals` is better here. ParseLoc.Stack wouldn't be used for >> anything so a regular boolean should suffice in this case. > > Can we add an `assert((flags != nullptr) == parsing_locals)` to express > intention? Currently, `flags` can never be null because it is always initialized to `_uninit_in_prev_frame_locals` or 0 for a full frame. In fact, the check for `flags != nullptr` can be removed. I'm not sure how this assert or a similar assert would work here since `flags` originate from the previous frame. I think we can simply assert that `flags != nullptr`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32242#discussion_r3751582332
