On Mon, 31 Aug 2026 20:39:23 GMT, Matias Saavedra Silva <[email protected]> wrote:
>> Early_larval frames can only apply to frames with the uninitializeThis flag >> set, however, this rule was not properly being enforced. Instead, the >> verifier looked at the state of uninitializedThis for the previous frame, so >> this patch moves this check until after the nested frame has been parsed. >> Verified with a new regresson test case and tier 1-5 tests. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Matias Saavedra Silva has updated the pull request incrementally with one > additional commit since the last revision: > > Dan comments I had one question, but otherwise looks good. It's really complicated but I think the code makes sense so well done! src/hotspot/share/classfile/stackMapTable.cpp line 323: > 321: return nullptr; > 322: } else { > 323: new_fields->put(tmp, false); If you have duplicate fields in the assert_unset_fields, would this add them twice? Should it be put_if_absent? ------------- Marked as reviewed by coleenp (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/32459#pullrequestreview-5095025076 PR Review Comment: https://git.openjdk.org/jdk/pull/32459#discussion_r3918598608
