On Wed, 2 Sep 2026 20:59:01 GMT, Coleen Phillimore <[email protected]> wrote:
>> Matias Saavedra Silva has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Dan comments
>
> src/hotspot/share/classfile/stackMapTable.cpp line 323:
>
>> 321: return nullptr;
>> 322: } else {
>> 323: new_fields->put(tmp, false);
>
> If you have duplicate fields in the assert_unset_fields, would this add them
> twice? Should it be put_if_absent?
HashTable's put method either inserts or replaces, there shouldn't be
duplicates.
```/**
* Inserts or replaces a value in the table.
* @return: true: if a new item is added
* false: if the item already existed and the value is updated
*/
bool put(K const& key, V const& value) {`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32459#discussion_r3926352272
