On Thu, 3 Sep 2026 13:02:59 GMT, Marc Chevalier <[email protected]> wrote:
>> That's true, but this is only the fall back implementation, so correctness >> and ease of implementation are more important. We will implement back-end >> support for these nodes later. > > In my experiments, CMove is not often as good as than a diamond from If + a > Phi, and rarely better. Even if cases where it looks like it should be good! > But it's not huge... so I agree to favor easiness, at least for now. While that's true, this macro node does not have control input and output, so building a diamond would be impossible. I always think that we can have `CMove` emit the diamond if it thinks that's suitable, since a `CMove`, while may have negative impacts on the generated code, helps simplify the graph. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31008#discussion_r3926045115
