On Thu, 3 Sep 2026 15:28:50 GMT, Quan Anh Mai <[email protected]> wrote:
>> In my experiments, CMove is not often as good as than a diamond from If + a >> Phi, and rarely better. Even if cases where it looks like it should be good! >> But it's not huge... so I agree to favor easiness, at least for now. > > While that's true, this macro node does not have control input and output, so > building a diamond would be impossible. I always think that we can have > `CMove` emit the diamond if it thinks that's suitable, since a `CMove`, while > may have negative impacts on the generated code, helps simplify the graph. Ah yes, there is no control also. Anyway, as I say, I'm all for simpler. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31008#discussion_r3931550728
