On Mon, 12 Oct 2026 21:16:25 GMT, Justin Lu <[email protected]> wrote:

> As the title suggests, permit `SyncProviderException.getSyncResolver()` to 
> throw `IllegalStateException` when a sync resolver cannot be loaded. Note, 
> there are no corresponding implementation changes in this PR.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

src/java.sql.rowset/share/classes/javax/sql/rowset/spi/SyncProviderException.java
 line 129:

> 127:      *     <code>SyncResolver(String)</code> constructors are used to 
> instantiate
> 128:      *     the <code>SyncResolver</code> instance.
> 129:      * @throws IllegalStateException if a {@code SyncResolver} cannot be 
> loaded.

For the description then I think it would be clearer to say something "if a 
SyncResolver is not set or the default implementation cannot be loaded". 
SyncProviderException has a setter method so calling that out helps to justify 
the ISE.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33329#discussion_r4255691231

Reply via email to