On Mon, 28 Sep 2026 06:16:14 GMT, Tagir F. Valeev <[email protected]> wrote:
>> Tagir F. Valeev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8391789: Empty input test fixed > > I updated the PR according to the latest suggestions: > - ListFormat.toCollector restored > - Collectors.joining(ListFormat) replaced with joiningConjunctively and > joiningDisjunctively accepting a Locale > - Every collector now produces an empty string for the empty stream. @amaembo Thanks for your patience. I've taken some time to think about this PR. Currently I am a bit on the fence about this feature, and I think that there are a couple of questions I think needs some elucidation before deciding how to move forward. 1. We currently don't really have any APIs that produce Collector instances outside of Collector and Collectors. 2. What's the likelyhood of someone looking for this Internalization-feature will look for it in Collectors? I can definitely see that if they find ListFormat they might discover a toCollector()-feature, however how likely is it for someone to be looking at Collectors.joining to decide that "joiningDisjunctively" vs "joiningConjunctively" is the right choice for them? I suspect that what we'll see is that there is a split between users coming to this from ListFormat and some who come from Collectors. What's uncertain to me, at this time, is if this is 50/50 or 90/10. At the end of the day, I want to make sure that we expand the API surface for the right reasons and with care. ------------- PR Comment: https://git.openjdk.org/jdk/pull/32716#issuecomment-6191203165
