On Thu, 22 Oct 2026 17:20:50 GMT, Justin Lu <[email protected]> wrote:

> `CachedRowSetWriter` is searching for **where** clauses within SQL queries. 
> However, these UPDATE and SELECT queries are manually re-constructed, and 
> will not contain **where** at that point that the search occurs. Thus, both 
> occurrences of these checks are incorrect, and their associated comments are 
> misleading. They should be removed to prevent erroneous stripping when an 
> identifier, such as a table name, contains the substring "where".
> 
> Testing done with stub classes.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

This pull request has now been integrated.

Changeset: b83ad056
Author:    Justin Lu <[email protected]>
URL:       
https://git.openjdk.org/jdk/commit/b83ad05687e66dbbeaefea4aa9af5ba9432570d5
Stats:     216 lines in 2 files changed: 176 ins; 40 del; 0 mod

8394143: CachedRowSet.acceptChanges fails when the table name contains “WHERE”

Reviewed-by: lancea

-------------

PR: https://git.openjdk.org/jdk/pull/33519

Reply via email to