On Fri, 23 Oct 2026 18:51:57 GMT, Justin Lu <[email protected]> wrote:

>> `CachedRowSetWriter` is searching for **where** clauses within SQL queries. 
>> However, these UPDATE and SELECT queries are manually re-constructed, and 
>> will not contain **where** at that point that the search occurs. Thus, both 
>> occurrences of these checks are incorrect, and their associated comments are 
>> misleading. They should be removed to prevent erroneous stripping when an 
>> identifier, such as a table name, contains the substring "where".
>> 
>> Testing done with stub classes.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Justin Lu has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Also check multiple row/col updates

Thanks for the review Lance.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33519#issuecomment-6421846628

Reply via email to