On Wed, 28 Oct 2026 18:57:17 GMT, Maurizio Cimadamore <[email protected]>
wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename withSign in the tests as well
>
> src/java.base/share/classes/java/lang/foreign/ValueLayout.java line 137:
>
>> 135: * by {@jls 5.1.2}, or zero extended as specified by the
>> 136: * {@link Integer#toUnsignedLong(int)} method. A user who is
>> interested
>> 137: * in widening values represented by integral value layouts may wish
>
> Again -- "represented"
Perhaps, more succinctly: "As such, the signedness of an integral value layout
allows clients to select the correct widening mode for values associated with
that layout"
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33417#discussion_r4404829254
