On Thu, 29 Oct 2026 22:21:20 GMT, Maurizio Cimadamore <[email protected]>
wrote:
>> test/jdk/java/foreign/normalize/TestZeroExtend.java line 49:
>>
>>> 47:
>>> 48: static {
>>> 49: System.loadLibrary("Normalize");
>>
>> Where is the native lib for this? I don't see any C file...
>>
>> Also, we should make sure that said lib is compiled with O1,2 -- otherwise
>> the test could pass even w/o the fix (I think)
>
> Ah I see -- the native lib was already there. Still, we should make sure to
> test against a library compiled with some (C) optimizations
The test fails without the fix. The native function is declared to accept
`int`, but we pass a smaller type. This essentially allows us to observe the
widening done by the bindings.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33417#discussion_r4423814145
