On Thu, 29 Oct 2026 14:19:52 GMT, Alan Bateman <[email protected]> wrote:
>>> Just surprising to see test/jdk/java/util/Formatter/Basic-X.java.template >>> changed as it looks like the issues with the incorrect BasicDateTime.java >>> should have its own issue so it can be separated from the update to the >>> tool/scripts. >> >> To verify my `genBasic.sh` changes, I needed to run the script, encountered >> the issue, and fixed it along. Would you like me to move the >> `test/jdk/java/util/Formatter/Basic-X.java.template` et al. changes to a >> follow-up ticket? > >> > Just surprising to see test/jdk/java/util/Formatter/Basic-X.java.template >> > changed as it looks like the issues with the incorrect BasicDateTime.java >> > should have its own issue so it can be separated from the update to the >> > tool/scripts. >> >> To verify my `genBasic.sh` changes, I needed to run the script, encountered >> the issue, and fixed it along. Would you like me to move the >> `test/jdk/java/util/Formatter/Basic-X.java.template` et al. changes to a >> follow-up ticket? > > I don't mind, I'm just trying to make sense of the change as it's more than > leaving Spp.class behind. @AlanBateman, @erikj79, thanks so much for the reviews. We haven't touched anything that would affect the result, though to be sure, I've verified that tiers 1-2 are clear on 1164860572f. ------------- PR Comment: https://git.openjdk.org/jdk/pull/33631#issuecomment-6735221756
