On Thu, 29 Oct 2026 12:41:27 GMT, Volkan Yazici <[email protected]> wrote:
>> Improve generator scripts invoking `Spp`: >> >> - Avoid leaving untracked files. >> - Fix undefined variable problems. >> - Fix arithmetic expression problems. >> - Add missing copyright headers. >> - Update scripts to allow invocation from an outside directory. >> - Move changes incorrectly landed on generated files back to their >> associated templates. (See >> `test/jdk/java/util/Formatter/Basic-X.java.template` changes in f8acb204.) >> - Some generator scripts were updated, but not run, hence their target >> content was missing changes. Introduce these missing changes. (See >> `test/jdk/jdk/incubator/vector/gen-tests.sh` changes in b211c0b7.) >> >> Changes are split in multiple contextual commits for review convenience. >> >> `test/micro/org/openjdk/bench/java/nio/ByteBuffers.java` should receive a >> copyright year update due to touched `genBuffers.sh` in the same directory. >> I've omitted this, since `ByteBuffers.java` will be modified soon in >> [JDK-8394658](https://bugs.openjdk.org/browse/JDK-8394658). >> >> --------- >> - [X] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision: > > Fix missing imports LGTM. Good catch on the misplaced datetime tests! ------------- Marked as reviewed by naoto (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/33631#pullrequestreview-5830357857
