On Tue, 17 Nov 2026 22:45:34 GMT, Naoto Sato <[email protected]> wrote:

> Fix the `RuleBasedCollator` parser to throw `ParseException` for unterminated 
> quoted text. Add regression tests and correct a missing closing quote in an 
> existing test rule, exposed by this fix.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Looks good.

test/jdk/java/text/Collator/G7Test.java line 26:

> 24: /*
> 25:  * @test
> 26:  * @library /java/text/testlib

I know the test did not contain the `bug` section, any reason to not include it 
going forward?

-------------

Marked as reviewed by jlu (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/33940#pullrequestreview-5962425298
PR Review Comment: https://git.openjdk.org/jdk/pull/33940#discussion_r4618684782

Reply via email to