On Wed, 18 Nov 2026 18:11:30 GMT, Justin Lu <[email protected]> wrote:

>> Fix the `RuleBasedCollator` parser to throw `ParseException` for 
>> unterminated quoted text. Add regression tests and correct a missing closing 
>> quote in an existing test rule, exposed by this fix.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> test/jdk/java/text/Collator/G7Test.java line 26:
> 
>> 24: /*
>> 25:  * @test
>> 26:  * @library /java/text/testlib
> 
> I know the test did not contain the `bug` section, any reason to not include 
> it going forward?

If this test catches a regression in the future and the implementation is 
fixed, the test should include the bug ID. However, this time, the issue was 
simply an error in the test itself, so I did not include it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33940#discussion_r4619075428

Reply via email to