On Wed, 3 Sep 2025 22:08:12 GMT, Alexey Semenyuk <[email protected]> wrote:
>> Armin Schrenk has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains four commits:
>>
>> - add tests
>> - Drop internal enum approach and only switch for Wix4 the architecture.
>> - Merge branch 'master' into JDK-8361207
>>
>> # Conflicts:
>> # src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WixPipeline.java
>> - Add support for arm64 Platform for jpackage/WixPipeline
>
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WixPipeline.java line
> 210:
>
>> 208: case Arch.X86 -> "x86";
>> 209: case Arch.AARCH64 -> "arm64";
>> 210: case Arch.OTHER -> throw new IOException("Unsupported
>> architecture.");
>
> This would rather be an instance of `UnsupportedOperationException`
Done in
https://github.com/openjdk/jdk/pull/26093/changes#diff-412dd6c7256ad9e8c12a89f9f131ad8357d7de608716ce33821072d5aad979b1R217
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WixPipeline.java line
> 264:
>
>> 262: case Arch.X64 -> "x64";
>> 263: case Arch.X86 -> "x86";
>> 264: case Arch.AARCH64, Arch.OTHER -> throw new
>> IOException("Unsupported architecture.");
>
> Is aarch64 packaging unsupported by WiX3?
WiX 3 started arm64 support with version 3.14, but this change deliberately
leaves WiX 3 unchanged because:
* it's out of community support since almost two years
* keeping the scope narrow (add arm64 support for WiX4 and above)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26093#discussion_r4641492957
PR Review Comment: https://git.openjdk.org/jdk/pull/26093#discussion_r4641486194