On Sat, 2 Aug 2025 13:40:26 GMT, Sebastian Stenzel <[email protected]> wrote:
>> Armin Schrenk has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains four commits: >> >> - add tests >> - Drop internal enum approach and only switch for Wix4 the architecture. >> - Merge branch 'master' into JDK-8361207 >> >> # Conflicts: >> # src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WixPipeline.java >> - Add support for arm64 Platform for jpackage/WixPipeline > > src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WixFragmentBuilder.java > line 166: > >> 164: } >> 165: } >> 166: > > isn't this enum definition redundant? Why not use `Architecture.current()` in > WixPipeline's switch expressions? I removed the enum and rely on `Architecture.current()` now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26093#discussion_r4641421212
