So the reasoning behind setting "awaiting merge" is because the "needs" label is meant to represent what is holding up the PR from being closed, and so a PR from a core dev is really just blocked on merging since they don't have to receive a review.
Now, if people would rather move it over to "needs review" by default like any other PR then that's fine as well, but I don't know if that's going to help with INADA-san's worry about so many issues making a label less useful. On Wed, 5 Sep 2018 at 05:45 Berker Peksağ <berker.pek...@gmail.com> wrote: > On Wed, Sep 5, 2018 at 3:28 PM INADA Naoki <songofaca...@gmail.com> wrote: > > Other option is set "awaiting review" label instead of > > "awaiting merge", like PRs from other contributors. > > +1. Personally, most of the time I request a review from another core > developer, so setting the "awaiting review" label seems reasonable to > me. > > --Berker > _______________________________________________ > core-workflow mailing list -- core-workflow@python.org > To unsubscribe send an email to core-workflow-le...@python.org > https://mail.python.org/mm3/mailman3/lists/core-workflow.python.org/ > This list is governed by the PSF Code of Conduct: > https://www.python.org/psf/codeofconduct >
_______________________________________________ core-workflow mailing list -- core-workflow@python.org To unsubscribe send an email to core-workflow-le...@python.org https://mail.python.org/mm3/mailman3/lists/core-workflow.python.org/ This list is governed by the PSF Code of Conduct: https://www.python.org/psf/codeofconduct
