FYI I opened a poll at https://discuss.python.org/t/poll-what-label-should-prs-from-core-devs-automatically-receive/970 to settle this question of what label core dev PRs whould automatically receive.
On Tue, Sep 11, 2018 at 2:49 PM Brett Cannon <br...@python.org> wrote: > > > On Tue, 11 Sep 2018 at 07:33 Nick Coghlan <ncogh...@gmail.com> wrote: > >> On Tue, 11 Sep 2018 at 05:13, Brett Cannon <br...@python.org> wrote: >> >>> On Mon, 10 Sep 2018 at 11:50 Mariatta Wijaya <mariatta.wij...@gmail.com> >>> wrote: >>> >>>> I prefer keeping the labeling as is, so core devs PR get "awaiting >>>> merge" label upon creation. >>>> >>>> If a core dev actually want someone else to review it, I suggest using >>>> the "request review" feature, and select another core dev to review the PR. >>>> >>> >>> Do the people wanting other core devs to review typically have someone >>> they want to review, or just anyone to do a review? >>> >> >> If I'm specifically waiting for feedback on a PR, I'll generally put an >> explicit "WIP: " (for work-in-progress) in the title to warn other folks >> not to merge it yet (it's a habit picked up when using GitLab, as that will >> actually prevent merging if you do that). >> > > We could set up a separate bot at this point, but with the new automerge > bot this won't be such an issue as people will simply not add the > "automerge" label until they are ready. > > >> >> So if folks don't want to make "No label" the default, then the >> convention could instead be to add "WIP: " to tell Bedevere to skip adding >> the "Awaiting merge" label. >> > > I think we may want to hold off on any changes until we see what happens > to our standard practices with the automerge bot. > > -Brett > > >> >> Cheers, >> Nick. >> >> -- >> Nick Coghlan | ncogh...@gmail.com | Brisbane, Australia >> >
_______________________________________________ core-workflow mailing list -- core-workflow@python.org To unsubscribe send an email to core-workflow-le...@python.org https://mail.python.org/mailman3/lists/core-workflow.python.org/ This list is governed by the PSF Code of Conduct: https://www.python.org/psf/codeofconduct
