On Tue, 11 Sep 2018 at 05:13, Brett Cannon <[email protected]> wrote: > On Mon, 10 Sep 2018 at 11:50 Mariatta Wijaya <[email protected]> > wrote: > >> I prefer keeping the labeling as is, so core devs PR get "awaiting merge" >> label upon creation. >> >> If a core dev actually want someone else to review it, I suggest using >> the "request review" feature, and select another core dev to review the PR. >> > > Do the people wanting other core devs to review typically have someone > they want to review, or just anyone to do a review? >
If I'm specifically waiting for feedback on a PR, I'll generally put an explicit "WIP: " (for work-in-progress) in the title to warn other folks not to merge it yet (it's a habit picked up when using GitLab, as that will actually prevent merging if you do that). So if folks don't want to make "No label" the default, then the convention could instead be to add "WIP: " to tell Bedevere to skip adding the "Awaiting merge" label. Cheers, Nick. -- Nick Coghlan | [email protected] | Brisbane, Australia
_______________________________________________ core-workflow mailing list -- [email protected] To unsubscribe send an email to [email protected] https://mail.python.org/mm3/mailman3/lists/core-workflow.python.org/ This list is governed by the PSF Code of Conduct: https://www.python.org/psf/codeofconduct
