On 10.07.2008 16:32, Stefan Reinauer wrote: > Peter Stuge wrote: > >> On Sat, Jul 05, 2008 at 04:35:29PM +0200, Carl-Daniel Hailfinger wrote: >> >> >>> mainboard-vendor = "Emulation"; >>> mainboard-name = "QEMU x86"; >>> + mainboard_pci_subsystem_vendor = "0x15ad"; >>> + mainboard_pci_subsystem_device = "0x1976"; >>> > Also, the assumption that there is a single subsystem ID for all devices > on a mainboard is wrong. There is no such ID per mainboard. Each device > can have a different subsystem ID. I suggest that we find a better > solution for that in v3. >
True. This patch was intended to move subsystem IDs to the DTS. Future patches to make the subsystem ID a per-device property are definitely the way to go. Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
