On 11.07.2008 13:59, Uwe Hermann wrote: > On Fri, Jul 11, 2008 at 03:06:43AM +0200, Carl-Daniel Hailfinger wrote: > >>> My goal was to have the same name in the dts which is also used as >>> variable name in C code. The existing code has a somewhat peculiar >>> mapping from organic growth over time: >>> mainboard-vendor -> const char *mainboard_vendor >>> mainboard-name -> const char *mainboard_part_number >>> If we can agree on whether the variable should be called >>> "mainboard_name" or "mainboard_part_number", I'd be willing to prepare a >>> patch. >>> > > mainboard_name sounds good. >
Indeed. The only problem is that this sort of conflicts with CONFIG_MAINBOARD_NAME, but that Kconfig variable is misnamed anyway (it contains the mainboard directory). >> OK, here comes a patch which makes mainboard-vendor naming more consistent. >> mainboard-name naming has been postponed because it's not clear what the >> real name should be. >> >> Generated code is identical to the state before the patch. >> >> Signed-off-by: Carl-Daniel Hailfinger <[EMAIL PROTECTED]> >> > > Acked-by: Uwe Hermann <[EMAIL PROTECTED]> > > Build-tested with a few targets. > Thanks, r694. Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
