Uwe Hermann wrote:
On Thu, Oct 02, 2008 at 02:46:35PM -0600, Marc Jones wrote:
Uwe Hermann wrote:
See patch. The pnp_dev_info[] was incomplete and partly wrong, due to
me doing blind copy-paste. After checking with the datasheet I _think_
the contents are correct now, but it would be nice if someone could
double-check that.
Various other superios have the same problem I'm afraid, I'll post more
patches later...
For parallel port there are _two_ base addresses (0x60/0x61 and 0x62/0x63),
but most other superios/boards only use the first one (I assume the
second set is only needed for some non-standard parallel port modes?)
Yeah, that is interesting since there is only one IRQ. I have never seen
a second lpt port used. I would ignore it.
OK.
Also, I left IT8712F_GPIO "empty" like this
{&ops, IT8712F_GPIO, },
even though it does have 0x60/0x61, 0x62/0x63, and 0x64/0x65 base address
registers, but those are "SMI# Normal Run Access Base Address" and
"Simple I/O Base Address" and "Panel Button De-bounce Base Address",
which I guess we don't need (?)
You could put it in for completeness but I doubt it will ever get used.
Yep, ok.
Why did the io_info.mask change from 0x7f8 to 0xfff8/c/f? That just
changes the granularity of of the resource? It is not a mask on the
address.
This is my biggest concern, I'm really not sure what values to put here.
My assumption was that those values are indeed bitmasks, specifying
which bits of the 0x60/0x61 registers shall be used for the I/O address.
For example: The IT8712F datasheet says for serial port 1:
8.5.2 Serial Port 1 Base Address MSB Register (Index=60h, Default=03h)
Bit Description
7-4 Read only as "0h" for Base Address[15:12].
3-0 Read/write, mapped as Base Address[11:8].
8.5.3 Serial Port 1 Base Address LSB Register (Index=61h, Default=F8h)
Bit Description
7-3 Read/write, mapped as Base Address[7:3].
2-0 Read only as "000b."
So bits 11..3 consitute the base address, the rest (15..12 and 2..0 are
zero and unused).
I used this information, the bitmask 0b0000111111111000, as the io_info.mask
values for the serial port (that's 0xff8 if converted to hex).
I see, I think that you are correct. The reserved bits indicate the
granularity which is then used in the resource allocation (size, limit,
granularity, and alignment. pnp_get_ioresource() is the function if you
care to look at it.
Acked-by: Marc Jones <[EMAIL PROTECTED]>
Marc
--
Marc Jones
Senior Firmware Engineer
(970) 226-9684 Office
mailto:[EMAIL PROTECTED]
http://www.amd.com/embeddedprocessors
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
