On Thu, Dec 18, 2008 at 3:18 AM, Carl-Daniel Hailfinger <
[email protected]> wrote:

> Bao, Zheng found a bug which killed SATA booting on my board.
>
> This happened because we do not error out on implicit function
> declarations. The linker has no way of checking whether the implicitly
> assumed function signature is identical to the real signature, so
> mismatches can occur and these mismatches are practically impossible to
> debug because the code looks completely correct.
>
> Adding -Werror-implicit-function-declaration to our CFLAGS would solve
> this problem nicely, but a lot of files in the tree need to be fixed.
>

I think this is a great idea.  Isn't the correct order to fix all the
warnings, then make it an error?

Thanks,
Myles
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to