On Thu, Dec 18, 2008 at 2:56 PM, Corey Osgood <[email protected]>wrote:
> On Thu, Dec 18, 2008 at 2:38 PM, Corey Osgood <[email protected]>wrote: > >> On Thu, Dec 18, 2008 at 2:28 PM, Myles Watson <[email protected]> wrote: >> >>> >>> >>> On Thu, Dec 18, 2008 at 12:24 PM, Corey Osgood >>> <[email protected]>wrote: >>> >>>> On Thu, Dec 18, 2008 at 11:37 AM, Corey Osgood >>>> <[email protected]>wrote: >>>> >>>>> On Thu, Dec 18, 2008 at 10:58 AM, ron minnich <[email protected]>wrote: >>>>> >>>>>> I like this idea a lot, I have no idea why we did not have that >>>>>> enabled before ... I'm glad I'm on vacation and you all can fix it :-) >>>>> >>>>> >>>>> I'm all for it. CN700 should be all ready for the change. >>>>> >>>> >>>> I retract that, I was thinking of v3. Attached patch fixes v2. >>>> >>> Index: src/northbridge/via/cn700/vgachip.h >>> =================================================================== >>> --- src/northbridge/via/cn700/vgachip.h (revision 3818) >>> +++ src/northbridge/via/cn700/vgachip.h (working copy) >>> @@ -1,6 +1,6 @@ >>> /* >>> * This file is part of the coreboot project. >>> - * >>> + *; >>> >>> I'm curious about this extra semicolon. Besides that: >>> >>> Acked-by: Myles Watson <[email protected]> >> >> >> Ah, I was looking for that! I have a bad habit of hitting my touchpad >> while typing and moving the cursor. Thanks, r3819 >> > > I just got another implicit declaration in i82810, and i82801xx is clean. > Someone ought to check i440bx, i830, and the other via chipsets, vt8623 will > probably have the same ones cn700 did, but I've got to get back to work. > Here's another patch to clear up a bunch more, not all of them by far. I'm for the most part avoiding k8 and sticking with the simpler ones. -Corey
Fix a LOT of implicit function declarations before they become errors. Signed-off-by: Corey Osgood <[email protected]> Index: src/southbridge/via/k8t890/k8t890_bridge.c =================================================================== --- src/southbridge/via/k8t890/k8t890_bridge.c (revision 3820) +++ src/southbridge/via/k8t890/k8t890_bridge.c (working copy) @@ -21,6 +21,7 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <console/console.h> +#include "k8t890.h" static void bridge_enable(struct device *dev) { Index: src/southbridge/via/k8t890/k8t890_pcie.c =================================================================== --- src/southbridge/via/k8t890/k8t890_pcie.c (revision 3820) +++ src/southbridge/via/k8t890/k8t890_pcie.c (working copy) @@ -22,6 +22,7 @@ #include <device/pci.h> #include <device/pciexp.h> #include <device/pci_ids.h> +#include "k8t890.h" static void peg_init(struct device *dev) { Index: src/southbridge/via/k8t890/k8t890_traf_ctrl.c =================================================================== --- src/southbridge/via/k8t890/k8t890_traf_ctrl.c (revision 3820) +++ src/southbridge/via/k8t890/k8t890_traf_ctrl.c (working copy) @@ -23,6 +23,8 @@ #include <console/console.h> #include "k8t890.h" +extern unsigned long log2(unsigned long x); + static void mmconfig_set_resources(device_t dev) { struct resource *resource; Index: src/southbridge/via/k8t890/k8t890_host_ctrl.c =================================================================== --- src/southbridge/via/k8t890/k8t890_host_ctrl.c (revision 3820) +++ src/southbridge/via/k8t890/k8t890_host_ctrl.c (working copy) @@ -22,6 +22,7 @@ #include <device/pci_ops.h> #include <device/pci_ids.h> #include <console/console.h> +#include "k8t890.h" /* this may be later merged */ Index: src/southbridge/via/k8t890/k8t890.h =================================================================== --- src/southbridge/via/k8t890/k8t890.h (revision 3820) +++ src/southbridge/via/k8t890/k8t890.h (working copy) @@ -35,4 +35,8 @@ /* the FB size in MB (min is 8MB max is 512MB) */ #define K8M890_FBSIZEMB 64 +#include <device/device.h> +extern void writeback(struct device *dev, u16 where, u8 what); +extern void dump_south(device_t dev); + #endif Index: src/include/pc80/keyboard.h =================================================================== --- src/include/pc80/keyboard.h (revision 3820) +++ src/include/pc80/keyboard.h (working copy) @@ -6,5 +6,6 @@ }; void init_pc_keyboard(unsigned port0, unsigned port1, struct pc_keyboard *kbd); +void set_kbc_ps2_mode(void); #endif /* PC80_KEYBOARD_H */ Index: src/cpu/intel/model_f2x/model_f2x_init.c =================================================================== --- src/cpu/intel/model_f2x/model_f2x_init.c (revision 3820) +++ src/cpu/intel/model_f2x/model_f2x_init.c (working copy) @@ -8,6 +8,7 @@ #include <cpu/x86/msr.h> #include <cpu/x86/lapic.h> #include <cpu/intel/microcode.h> +#include <cpu/intel/hyperthreading.h> #include <cpu/x86/cache.h> #include <cpu/x86/mtrr.h> Index: src/mainboard/amd/pistachio/fadt.c =================================================================== --- src/mainboard/amd/pistachio/fadt.c (revision 3820) +++ src/mainboard/amd/pistachio/fadt.c (working copy) @@ -26,6 +26,7 @@ #include <arch/acpi.h> #include <arch/io.h> +extern void pm_iowrite(u8 reg, u8 value); /*extern*/ u16 pm_base = 0x800; /* pm_base should be set in sb acpi */ /* pm_base should be got from bar2 of rs690. Here I compact ACPI Index: src/mainboard/amd/pistachio/mainboard.c =================================================================== --- src/mainboard/amd/pistachio/mainboard.c (revision 3820) +++ src/mainboard/amd/pistachio/mainboard.c (working copy) @@ -37,6 +37,9 @@ extern int do_smbus_read_byte(u32 smbus_io_base, u32 device, u32 address); extern int do_smbus_write_byte(u32 smbus_io_base, u32 device, u32 address, u8 val); +extern void lb_add_memory_range(struct lb_memory *mem, uint32_t type, + uint64_t start, uint64_t size); + #define ADT7475_read_byte(address) \ do_smbus_read_byte(SMBUS_IO_BASE, ADT7475_ADDRESS, address) #define ADT7475_write_byte(address, val) \ Index: src/mainboard/dell/s1850/reset.c =================================================================== --- src/mainboard/dell/s1850/reset.c (revision 3820) +++ src/mainboard/dell/s1850/reset.c (working copy) @@ -1,4 +1,5 @@ #include <arch/io.h> +#include <device/pci.h> #include <device/pci_def.h> #include <device/pci_ids.h> #ifndef __ROMCC__ Index: src/northbridge/amd/gx1/northbridge.c =================================================================== --- src/northbridge/amd/gx1/northbridge.c (revision 3820) +++ src/northbridge/amd/gx1/northbridge.c (working copy) @@ -11,6 +11,7 @@ #include "northbridge.h" #include <cpu/amd/gx1def.h> #include <cpu/x86/cache.h> +#include <cpu/cpu.h> #define NORTHBRIDGE_FILE "northbridge.c" /* Index: src/northbridge/amd/gx2/chipsetinit.c =================================================================== --- src/northbridge/amd/gx2/chipsetinit.c (revision 3820) +++ src/northbridge/amd/gx2/chipsetinit.c (working copy) @@ -14,7 +14,7 @@ #include <cpu/x86/cache.h> #include "../../../southbridge/amd/cs5536/cs5536.h" - +extern int sizeram(void); /* the structs in this file only set msr.lo. But ... that may not always be true */ struct msrinit { Index: src/northbridge/amd/gx2/northbridge.c =================================================================== --- src/northbridge/amd/gx2/northbridge.c (revision 3820) +++ src/northbridge/amd/gx2/northbridge.c (working copy) @@ -13,6 +13,7 @@ #include <cpu/x86/msr.h> #include <cpu/x86/cache.h> #include <cpu/amd/vr.h> +#include <cpu/cpu.h> #include "../../../southbridge/amd/cs5536/cs5536.h" #define VIDEO_MB 8 Index: src/northbridge/amd/lx/northbridge.c =================================================================== --- src/northbridge/amd/lx/northbridge.c (revision 3820) +++ src/northbridge/amd/lx/northbridge.c (working copy) @@ -32,6 +32,7 @@ #include <cpu/x86/msr.h> #include <cpu/x86/cache.h> #include <cpu/amd/vr.h> +#include <cpu/cpu.h> #include "chip.h" #include "northbridge.h" #include "../../../southbridge/amd/cs5536/cs5536.h" Index: src/northbridge/amd/amdk8/northbridge.c =================================================================== --- src/northbridge/amd/amdk8/northbridge.c (revision 3820) +++ src/northbridge/amd/amdk8/northbridge.c (working copy) @@ -16,6 +16,7 @@ #include <string.h> #include <bitops.h> #include <cpu/cpu.h> +#include <cpu/amd/model_fxx_rev.h> #include <cpu/x86/lapic.h> Index: src/northbridge/intel/i855pm/northbridge.c =================================================================== --- src/northbridge/intel/i855pm/northbridge.c (revision 3820) +++ src/northbridge/intel/i855pm/northbridge.c (working copy) @@ -3,6 +3,7 @@ #include <stdint.h> #include <device/device.h> #include <device/pci.h> +#include <device/pci_ids.h> #include <stdlib.h> #include <string.h> #include <bitops.h> @@ -13,7 +14,6 @@ static void pci_domain_read_resources(device_t dev) { struct resource *resource; - unsigned reg; /* Initialize the system wide io space constraints */ resource = new_resource(dev, IOINDEX_SUBTRACTIVE(0, 0)); Index: src/northbridge/intel/i440bx/northbridge.c =================================================================== --- src/northbridge/intel/i440bx/northbridge.c (revision 3820) +++ src/northbridge/intel/i440bx/northbridge.c (working copy) @@ -7,6 +7,8 @@ #include <stdlib.h> #include <string.h> #include <bitops.h> +#include <cpu/cpu.h> +#include <pc80/keyboard.h> #include "chip.h" #include "northbridge.h" #include "i440bx.h"
-- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot

