On Thu, Dec 18, 2008 at 11:37 AM, Corey Osgood <[email protected]>wrote:

> On Thu, Dec 18, 2008 at 10:58 AM, ron minnich <[email protected]> wrote:
>
>> I like this idea a lot, I have no idea why we did not have that
>> enabled before ... I'm glad I'm on vacation and you all can fix it :-)
>
>
> I'm all for it. CN700 should be all ready for the change.
>

I retract that, I was thinking of v3. Attached patch fixes v2.

-Corey
Fix implicit declaration in cn700/vt8237 code

Signed-off-by: Corey Osgood <[email protected]>

Index: src/southbridge/via/vt8237r/vt8237r.c
===================================================================
--- src/southbridge/via/vt8237r/vt8237r.c       (revision 3818)
+++ src/southbridge/via/vt8237r/vt8237r.c       (working copy)
@@ -21,7 +21,6 @@
 #include <device/device.h>
 #include <device/pci.h>
 #include <device/pci_ids.h>
-#include <pc80/keyboard.h>
 #include "chip.h"
 
 /*
Index: src/southbridge/via/vt8237r/vt8237r_lpc.c
===================================================================
--- src/southbridge/via/vt8237r/vt8237r_lpc.c   (revision 3818)
+++ src/southbridge/via/vt8237r/vt8237r_lpc.c   (working copy)
@@ -26,6 +26,7 @@
 #include <device/pci_ids.h>
 #include <pc80/mc146818rtc.h>
 #include <cpu/x86/lapic.h>
+#include <pc80/keyboard.h>
 #include <stdlib.h>
 #include "vt8237r.h"
 #include "chip.h"
@@ -46,6 +47,7 @@
 #define INT            (1 << 8)
 
 extern void dump_south(device_t dev);
+extern void setup_i8259(void);
 
 static struct ioapicreg {
        u32 reg;
Index: src/northbridge/via/cn700/vgachip.h
===================================================================
--- src/northbridge/via/cn700/vgachip.h (revision 3818)
+++ src/northbridge/via/cn700/vgachip.h (working copy)
@@ -1,6 +1,6 @@
 /*
  * This file is part of the coreboot project.
- *
+ *;
  * Copyright (C) 2007 Corey Osgood <[email protected]>
  *
  * This program is free software; you can redistribute it and/or modify
@@ -27,4 +27,9 @@
        int nothing;
 };
 
+void vga_enable_console(void);
+void do_vgabios(void);
+void setup_realmode_idt(void);
+void write_protect_vgabios(void);
+
 #endif /* _PC80_VGABIOS */
Index: src/northbridge/via/cn700/vga.c
===================================================================
--- src/northbridge/via/cn700/vga.c     (revision 3818)
+++ src/northbridge/via/cn700/vga.c     (working copy)
@@ -36,6 +36,7 @@
 #include "chip.h"
 #include "northbridge.h"
 #include "cn700.h"
+#include "vgachip.h"
 
 void write_protect_vgabios(void)
 {
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to