On 06.03.2009 18:24, [email protected] wrote: > Author: stepan > Date: 2009-03-06 18:24:29 +0100 (Fri, 06 Mar 2009) > New Revision: 3977 > > fix a bunch of cast and type warnings and don't call the apic "nvram", that > doesn't make no sense. (trivial) >
The change to the ROUND macro is rather non-trivial. It changes the formula. If the new formula is indeed what you want, one parenthesis can be removed: #define ROUND(_r,_a) (((_r) + ((_a) - 1)) & ~((_a) - 1)) Regards, Carl-Daniel > Signed-off-by: Stefan Reinauer <[email protected]> > Acked-by: Stefan Reinauer <[email protected]> > > Modified: trunk/coreboot-v2/src/arch/i386/boot/multiboot.c > =================================================================== > --- trunk/coreboot-v2/src/arch/i386/boot/multiboot.c 2009-03-06 17:22:35 UTC > (rev 3976) > +++ trunk/coreboot-v2/src/arch/i386/boot/multiboot.c 2009-03-06 17:24:29 UTC > (rev 3977) > @@ -72,7 +72,7 @@ > build_mb_mem_range_nooverlap(res->base, res->size); > } > > -#define ROUND(_r,_a) ((_r) + (((_a) - 1)) & ~((_a) - 1)) > +#define ROUND(_r,_a) (((_r) + (((_a) - 1))) & ~((_a) - 1)) > > unsigned long write_multiboot_info( > unsigned long low_table_start, unsigned long low_table_end, > -- http://www.hailfinger.org/ -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
