On 06.03.2009 19:57 Uhr, Myles Watson wrote:
> On Fri, Mar 6, 2009 at 11:36 AM, Carl-Daniel Hailfinger
> <[email protected]> wrote:
>
>> On 06.03.2009 18:24, [email protected] wrote:
>>
>>> Author: stepan
>>> Date: 2009-03-06 18:24:29 +0100 (Fri, 06 Mar 2009)
>>> New Revision: 3977
>>>
>>> fix a bunch of cast and type warnings and don't call the apic "nvram", that
>>> doesn't make no sense. (trivial)
>>>
>>>
>> The change to the ROUND macro is rather non-trivial. It changes the
>> formula. If the new formula is indeed what you want, one parenthesis can
>> be removed:
>>
>> #define ROUND(_r,_a) (((_r) + ((_a) - 1)) & ~((_a) - 1))
>>
>
> I agree that a parenthesis can be removed, but since + has precedence
> over & I don't see how the formula was changed.
>
gcc was complaining about missing paranthesis, so I figured I'd try to
make clear what it's supopsed to do.
--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: [email protected] • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
