On 27.04.2009 21:43, Carl-Daniel Hailfinger wrote: > On 27.04.2009 21:41, Patrick Georgi wrote: > >> Am 27.04.2009 21:26, schrieb ron minnich: >> >>> I think moving the v3 style printk to v2 makes the most sense. >>> >> Would that fix the issue I brought up? >> > > AFAICS it wouldn't.
Apologies for that incorrect statement. I had remembered a patch which changed v3 to the v2 style of compiling out some messages (which would have resulted in three different printk levels (compiled-in messages, printed-by-default messages and printed-with-current-level messages) instead of only two levels) and thought that had been committed. Maybe it was Myles who posted that patch, I can't remember anymore. > But romcc interactions might become "interesting" > (register shortage etc.). > The ROMCC interactions are still a probably valid concern. ROM size might become a problem as well. After all, not everybody needs all SPEW level messages compiled in. To be honest, the longer I think about it, the more I favour the three-level approach with the ability to compile some messages out. Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
