On 5/16/10 6:46 PM, Rudolf Marek wrote: > > > OpenPGP: *Attachments to this message have not been signed or encrypted* > > ********* *BEGIN ENCRYPTED or SIGNED PART* ********* > > Hello, > > Following patch reworks car_disable into C. Tested, works here. I compared > also the GCC generated code and it looks all right. Please test on some > multicore CPU. >
A potential Todo on my list was to straighten out cache_as_ram on K8/K10 in the same way as we did on all the other functions, and that would mean calling post_cache_as_ram() from assembler directly, so we don't have to add the call to each and every romstage.c:main() function. That might include a second jump to a C function, or significantly stripping down post_cache_as_ram() for those CPUs so it can easily be added in assembler like on the other CPUs. What do you think? > I added the "memory" clobber to read_cr0 / write_cr0 function as it is in > Linux > Kernel. Seems that if this is missing, GCC is too smart and messes the order > of reads/writes to CR0 (not tested if really a problem here, but be safe for > future users of this function ;) > > Signed-off-by: Rudolf Marek <[email protected]> > Acked-by: Stefan Reinauer <[email protected]> > Maybe we can add nice copyright header too? > Please do! -- coresystems GmbH . Brahmsstr. 16 . D-79104 Freiburg i. Br. Tel.: +49 761 7668825 . Fax: +49 761 7664613 Email: [email protected] . http://www.coresystems.de/ Registergericht: Amtsgericht Freiburg . HRB 7656 Geschäftsführer: Stefan Reinauer . Ust-IdNr.: DE245674866
-- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
