+ // fix made by Marc Bertens <[email protected]> + if (link > 0x5f) { + // This is basically for the 440BX + link -= 0x5f; + }
I'd prefer this to be guarded by #if CONFIG_NORTHBRIDGE_INTEL_440BX (or whatever the correct one is) It would also be nice to have an explanation. The rest of your patch touches a lot of code with little explanation. It takes a lot more time to review patches like that. For a faster review you should split it up into pieces that add functionality. For example, the heap size (which seems really large) part of the patch should have an explanation of what problem you see with a normal heap size. Thanks, Myles -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
