On Tue, Oct 5, 2010 at 3:28 PM, Warren Turkal <[email protected]> wrote: > The common mtrr registers are separated into their own macros. For > instance, check out the AMD car code. AMD has additional mtrr > registers that are used. There is an AMD_MTRR_MSRS_TABLE_ENTRIES_ASM > as a result. Is this not enough to separate the vendors? > > Or is your assertion that the values in > X86_MTRR_MSRS_TABLE_ENTRIES_ASM can vary?
oops, I misread it. OK, got it, makes sense. I think you can leave the _ASM off since you are using as .macro anyway -- you can't use it anywhere but assembly. If we're all certain that those registers are all safely common across all systems, I guess it works for me. Possibly we should get some testing to make sure it's good. ron -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
