On Wed, Oct 06, 2010 at 06:51:13AM -0600, Myles Watson wrote: > > + /* fixed mtrr MSRs */ > > + .long MTRRfix64K_00000_MSR > > + .long MTRRfix16K_80000_MSR > > + .long MTRRfix16K_A0000_MSR > I'm fine with replacing the magic numbers, but moving the lists to ASM
Yep. > macros in C header files, when they're only used in this one place, > doesn't make sense to me. They're only used once per cache_as_ram.inc file, but every such file has that list, so putting the list in an mtrr_defs.inc or the like and using ".include mtrr_defs.inc" in every cache_as_ram.inc would be nice IMHO. Uwe. -- http://hermann-uwe.de | http://sigrok.org http://randomprojects.org | http://unmaintained-free-software.org -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
