On Thu, Feb 24, 2011 at 2:27 PM, xdrudis <[email protected]> wrote: > On Thu, Feb 24, 2011 at 02:31:29PM +0100, Georgi, Patrick wrote: >> Am Donnerstag, den 17.02.2011, 07:35 +0100 schrieb xdrudis: >> > see patch >> Any opinion on these patches? Patch 1-8 seem to be refactorings only, >> and splitting functions into smaller logical units looks good to me, but >> I'd like to hear from someone deeper in the AMD code. >> > > Yes, if these 8 are not refactorings, then it's a bug. > > I know it's a little work to review it all, but it does not have > to be one person. You can review just one patch, maybe. > > Testing is maybe better to do with all of them, or all without > negative reviews, or something. I've tested them one by one > and it is a little a waste of time. And I haven't found a single > one that fixes it for me. Must be a combination, possibly not > all but not sure which ones. They're secuential although not > each and every one needs all previous ones. > > By the way testing for both SVI and PVI is welcome (for AMD FAM 10). > I don't intend to break PVI, but I can't test it. > > Some of the later ones may be a little paranoid or a matter of taste > but I tried to split them in small pieces so they can be rejected > or modified.
Acked-by: Marc Jones <[email protected]> r6387 -- http://se-eng.com -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
