Hi, Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan.
1 new defect(s) introduced to coreboot found with Coverity Scan. 49 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1364082: Integer handling issues (NO_EFFECT) /src/soc/rockchip/common/spi.c: 170 in rockchip_spi_set_sample_delay() ________________________________________________________________________________________________________ *** CID 1364082: Integer handling issues (NO_EFFECT) /src/soc/rockchip/common/spi.c: 170 in rockchip_spi_set_sample_delay() 164 assert(bus >= 0 && bus < ARRAY_SIZE(rockchip_spi_slaves)); 165 struct rockchip_spi *regs = rockchip_spi_slaves[bus].regs; 166 unsigned int rsd; 167 168 /* Rxd Sample Delay */ 169 rsd = DIV_ROUND_CLOSEST(delay_ns * (SPI_SRCCLK_HZ >> 8), 1*GHz >> 8); >>> CID 1364082: Integer handling issues (NO_EFFECT) >>> This greater-than-or-equal-to-zero comparison of an unsigned value is >>> always true. "rsd >= 0U". 170 assert(rsd >= 0 && rsd <= 3); 171 clrsetbits_le32(®s->ctrlr0, SPI_RXDSD_MASK << SPI_RXDSD_OFFSET, 172 rsd << SPI_RXDSD_OFFSET); 173 } 174 175 int spi_claim_bus(struct spi_slave *slave) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbLuoVetFLSjdonCi1EjfHRqWGQvojmmkYaBE-2BPJiTQvQ-3D-3D_q4bX76XMySz3BXBlWr5fXXJ4cvAsgEXEqC7dBPM7O5bahXuYnu8yBwLXwJ4QxC74PrU-2FAu4aq4FAHNDtkFg6GeioKxEmjzlc2qvNFffqXYY4EMg-2FeURjPfqPq3U-2By-2FAW1txkSxwTwV75jBLmOY6uV5wayW743uSXO7-2BYSM5bRAPcBpSRK6hApSK5O-2FlSxQa7tkQVmVvxIbI9nKCQbgnF2f9emHEeMthZEBTWCJsut3o-3D To manage Coverity Scan email notifications for "coreboot@coreboot.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4e-2BpBzwOa5gzBZa9dWpDbzfofODnVj1enK2UkK0-2BgCCqyeem8IVKvTxSaOFkteZFcnohwvb2rnYNjswGryEWCURnUk6WHU42sbOmtOjD-2Bx5c-3D_q4bX76XMySz3BXBlWr5fXXJ4cvAsgEXEqC7dBPM7O5bahXuYnu8yBwLXwJ4QxC74JwZHzg8C5P8V9bzL4cwXah544S3IlJGDyK2sL1OtO0mnlmP8g5zv8r6MEr0Y3-2FSZn3ldccxiH-2B6UNu1Hy1Vel2Hg-2BeExGY4-2BGzhMxg9xXG4-2BA-2Bqi8uxKAPWAVUE0C6NOM4gCPtevBZWbzmOXTLNTOaFDaTC1Z9TojoshUt4heq4-3D -- coreboot mailing list: coreboot@coreboot.org https://www.coreboot.org/mailman/listinfo/coreboot
