Hi,
Please find the latest report on new defect(s) introduced to coreboot found
with Coverity Scan.
1 new defect(s) introduced to coreboot found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1364118: Integer handling issues (NO_EFFECT)
/src/northbridge/intel/x4x/gma.c: 190 in intel_gma_init()
________________________________________________________________________________________________________
*** CID 1364118: Integer handling issues (NO_EFFECT)
/src/northbridge/intel/x4x/gma.c: 190 in intel_gma_init()
184 for (candp1 = 8; candp1 >= 1; candp1--)
{
185 u32 m = 5 * (candm1 + 2) +
(candm2 + 2);
186 u32 p = candp1 * 10; /* 10 ==
p2 */
187 u32 vco = DIV_ROUND_CLOSEST(
188 BASE_FREQUENCY * m,
candn + 2);
189 u32 dot =
DIV_ROUND_CLOSEST(vco, p);
>>> CID 1364118: Integer handling issues (NO_EFFECT)
>>> This less-than-zero comparison of an unsigned value is never true. "dot
>>> - target_frequency < 0U".
190 u32 this_err = ABS(dot -
target_frequency);
191 if (this_err < err_most) {
192 err_most = this_err;
193 pixel_n = candn;
194 pixel_m1 = candm1;
195 pixel_m2 = candm2;
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbLuoVetFLSjdonCi1EjfHRqWGQvojmmkYaBE-2BPJiTQvQ-3D-3D_q4bX76XMySz3BXBlWr5fXXJ4cvAsgEXEqC7dBPM7O5bRN1d1naGthCAIGJgQatCGxxlXTbJMeuo7MZDJzp4augveZf6wSeOhe-2B2qB8VtVmBuzK1S5HBYHor6ju7qelbeE4Uqtgi41dX-2BFI3szS9oEu-2FBYRl7A4oxnNHStZtjnrcOlSMZtwM7QmpIG8hStxMc1LxWHItlb-2BElCFT4nvTdTrxc1BRKjgV9mxF1uKlqQHw-3D
To manage Coverity Scan email notifications for "coreboot@coreboot.org", click
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4e-2BpBzwOa5gzBZa9dWpDbzfofODnVj1enK2UkK0-2BgCCqyeem8IVKvTxSaOFkteZFcnohwvb2rnYNjswGryEWCURnUk6WHU42sbOmtOjD-2Bx5c-3D_q4bX76XMySz3BXBlWr5fXXJ4cvAsgEXEqC7dBPM7O5bRN1d1naGthCAIGJgQatCGQfoQHOIq6A01SPQ-2Fpl2Bp2dS-2FsGrb08jtpaKLC5mrmAMl3I1-2BpSaLhEA9zkeAlgZgndhx3cU-2Ff2uXZ6fQQMBTcL-2FfWVmM81xEHDICf3XdCyUg0kqvw3734-2FxOM1QJaUJ9HUvfkDrDgcoGn7bZAXVBRT-2BYMkQe0AbvFGHsNXAk0w-3D
--
coreboot mailing list: coreboot@coreboot.org
https://www.coreboot.org/mailman/listinfo/coreboot
