I uploaded a status report for the X201 and it contains the smashed stack message. Since then I booted several times but was not able to reproduce this stack smashing issue. It seems like that this kind of error occurs only once after flashing. Please find attached a diff of the notable differences of a new console log compared to the one I pushed to board-status. It supports that there is an issue with the initial raminit.
Cheers, Matthias On 02/05/18 20:12, ron minnich wrote: > Yeah I think you want to hunt this stack smash error down, it's not > something you want to ignore. > > On Wed, May 2, 2018 at 11:09 AM Kyösti Mälkki <[email protected]> > wrote: > >> On Wed, May 2, 2018 at 8:53 PM, Nico Huber <[email protected]> wrote: >>> On 02.05.2018 18:37, qtux wrote: >>>> Thanks for your detailed explanation. So in essence shall I ignore the >>>> messages or blacklist lpc_ich? >>> >>> Yes, either ;) >>> >>>> >>>> Besides, while preparing the status report, I sometimes find a "Smashed >>>> stack detected in romstage!" message in the console log, just before >>>> ramstage is starting. Is there something to worry about there? >>> >>> Um, yes. I think that's not good. But I wonder why it's not happening >>> consistently. >> >> I commented about that earlier in this thread. Seemed like actual >> raminit eats a lot of stack, but loading from MRC cache or equivalent >> does not. One could find that struct and move it to BSS, declared with >> CAR_GLOBAL. I would rather not extend the boundary for stack-smashing >> detection. >> >> Kyösti >> >> -- >> coreboot mailing list: [email protected] >> https://mail.coreboot.org/mailman/listinfo/coreboot >
diff --git a/lenovo/x201/4.7-994-ga940e384b6/2018-05-03T17_19_05Z/coreboot_console.txt b/lenovo/x201/4.7-994-ga940e384b6/2018-05-03T17_19_05Z/coreboot_console.txt index 6c73a758a..20bffc5c7 100644 --- a/lenovo/x201/4.7-994-ga940e384b6/2018-05-03T17_19_05Z/coreboot_console.txt +++ b/lenovo/x201/4.7-994-ga940e384b6/2018-05-03T17_19_05Z/coreboot_console.txt @@ -99,10 +100,6 @@ ME: Error Code : No Error ME: Progress Phase : BUP Phase ME: Power Management Event : Clean Moff->Mx wake ME: Progress Phase State : 0x41 -Smashed stack detected in romstage! -Smashed stack detected in romstage! -Smashed stack detected in romstage! -Smashed stack detected in romstage! MTRR Range: Start=ff800000 End=0 (Size 800000) MTRR Range: Start=0 End=1000000 (Size 1000000) MTRR Range: Start=bf000000 End=bf800000 (Size 800000) @@ -860,7 +857,7 @@ SMM Module: stub loaded at bf808000. Will call bf8101a6(00000000) Initializing southbridge SMI... ... pmbase = 0x0500 SMI_STS: MCSMI PM1 -PM1_STS: WAK BM TMROF +PM1_STS: WAK BM GPE0_STS: GPIO14 GPIO11 GPIO9 GPIO5 GPIO4 GPIO3 GPIO2 GPIO1 GPIO0 ALT_GP_SMI_STS: GPI14 GPI13 GPI11 GPI10 GPI9 GPI7 GPI6 GPI5 GPI4 GPI3 GPI2 GPI1 GPI0 TCO_STS: @@ -1301,17 +1298,13 @@ Updating MRC cache data. CBFS: 'Master Header Locator' located CBFS at [700200:7fffc0) CBFS: Locating 'mrc.cache' CBFS: Found @ offset 1fdc0 size 10000 -find_current_mrc_cache_local: picked entry 0 from cache block -Manufacturer: c2 -SF: Detected MX25L6405D with sector size 0x1000, total 0x800000 -find_next_mrc_cache: picked next entry from cache block at fff21000 -Finally: write MRC cache update to flash at fff21000 -Successfully wrote MRC cache -BS: BS_DEV_INIT times (us): entry 5 run 145643 exit 14099 +find_current_mrc_cache_local: picked entry 1 from cache block +MRC data in flash is up to date. No update. +BS: BS_DEV_INIT times (us): entry 5 run 145972 exit 12026 Finalize devices... PCI: 00:1f.0 final Devices finalized @@ -1472,7 +1465,7 @@ SF: Detected MX25L6405D with sector size 0x1000, total 0x800000 CBFS: 'Master Header Locator' located CBFS at [700200:7fffc0) FMAP: Found "FLASH" version 1.1 at 700000. FMAP: base = ff800000 size = 800000 #areas = 3 -Wrote coreboot table at: bf746000, 0x36c bytes, checksum acd2 +Wrote coreboot table at: bf746000, 0x36c bytes, checksum 50d2 coreboot table: 900 bytes. IMD ROOT 0. bf7ff000 00001000 IMD SMALL 1. bf7fe000 00001000 @@ -1538,14 +1531,16 @@ AHCI controller at 00:1f.2, iobase 0xcfd26000, irq 11 Found 0 lpt ports Found 0 serial ports Searching bootorder for: /rom@img/memtest -Discarding ps2 data aa (status=11) Searching bootorder for: /pci@i0cf8/*@1f,2/drive@0/disk@0 AHCI/0: Set transfer mode to UDMA-5 AHCI/0: registering: "AHCI/0: M4-CT128M4SSD2 ATA-9 Hard-Disk (119 GiBytes)" Initialized USB HUB (0 ports used) +WARNING - Timeout at ps2_recvbyte:182! +Discarding ps2 data aa (status=11) +WARNING - Timeout at ps2_recvbyte:182! PS2 keyboard initialized WARNING - Timeout at ehci_wait_td:516! -ehci pipe=0xbf6c1080 cur=bf6b5dc0 tok=80080d80 next=bf6b5e00 td=0xbf6b5dc0 status=80080d80 +ehci pipe=0xbf6c1080 cur=bf6b4dc0 tok=80080d80 next=bf6b4e00 td=0xbf6b4dc0 status=80080d80 Initialized USB HUB (0 ports used) All threads complete. Scan for option roms
-- coreboot mailing list: [email protected] https://mail.coreboot.org/mailman/listinfo/coreboot
