Beware that patch is incomplete! Coreboot dies at
src/southbridge/intel/common/acpi_pirq_gen.c line 97:
if (!lpcb_path)
die("ACPI_PIRQ_GEN: Missing LPCB ACPI path\n");
You have to add the lpc_acpi_name function to
src/southbridge/intel/ibexpeak/lpc.c as in
src/southbridge/intel/bd82x6x/lpc.c to circumvent this issue.
I was preparing to upload my patch when I saw yours (which is almost
identical). Additionally, I already tested my patch on a Lenovo X201i.
Shall I edit your patch on gerrit or upload mine in a separate merge
request, or do something else?
Cheers,
Matthias
On 01/05/18 18:45, Kyösti Mälkki wrote:
> On Mon, Apr 30, 2018 at 6:46 AM, qtux <[email protected]> wrote:
>> I wrote a patch [0] for the finalize code issue. With that my X201i is
>> working fine on current master besides an regression introduced in commit
>> 7f5efd90e598320791200e03f761309ee04b58a3 [1]. With that regression USB and
>> SD card is not working anymore and it raises the following errors:
>
> Thanks for patching _and_ testing, your patch for finalize was just merged.
>
>> can't derive routing for PCI INT A
>> PCI INT A: no GSI
>
> As for IRQ regressions, I think I can see where it went wrong, find my
> attempt to fix it blind-folded [1].
>
> [1] https://review.coreboot.org/#/c/coreboot/+/25965
>
> Kyösti
>
--
coreboot mailing list: [email protected]
https://mail.coreboot.org/mailman/listinfo/coreboot
