Hi,
Please find the latest report on new defect(s) introduced to coreboot found
with Coverity Scan.
1 new defect(s) introduced to coreboot found with Coverity Scan.
3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1400679: Incorrect expression (COPY_PASTE_ERROR)
/src/arch/x86/smbios.c: 653 in smbios_write_type7()
________________________________________________________________________________________________________
*** CID 1400679: Incorrect expression (COPY_PASTE_ERROR)
/src/arch/x86/smbios.c: 653 in smbios_write_type7()
647 t->max_cache_size = max_cache_size / KiB;
648 t->max_cache_size2 = t->max_cache_size;
649
650 t->max_cache_size |= SMBIOS_CACHE_SIZE_UNIT_1KB;
651 t->max_cache_size2 |= SMBIOS_CACHE_SIZE2_UNIT_1KB;
652 } else {
>>> CID 1400679: Incorrect expression (COPY_PASTE_ERROR)
>>> "cache_size" in "cache_size < 2147418112UL" looks like a copy-paste
>>> error.
653 if (cache_size < (SMBIOS_CACHE_SIZE_MASK * 64 * KiB))
654 t->max_cache_size = max_cache_size / (64 * KiB);
655 else
656 t->max_cache_size = SMBIOS_CACHE_SIZE_OVERFLOW;
657 t->max_cache_size2 = max_cache_size / (64 * KiB);
658
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbLuoVetFLSjdonCi1EjfHRqWGQvojmmkYaBE-2BPJiTQvaU4HClancRgJSp1vcdHRWU-3D_q4bX76XMySz3BXBlWr5fXXJ4cvAsgEXEqC7dBPM7O5b55e5bbu9v133jh0eRPIJWq9PC7D26qht9vDaBM6kbkTSxZZ9WJOmKA4PidkL3-2F73qNeaD8JiAZMy0xDW4FHl0Bq2cQNVrfFWWY4e8V3aS3egoZ7k9ZCrWcsYUdrEI0LcVCHtTmxdR-2FTxAlZjwOVnvTmgpP4tKCOzKbYN7Kxss6wi2D-2BWWZjasmh1Gkzzmf2A-3D
_______________________________________________
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-le...@coreboot.org
