Hi,
Please find the latest report on new defect(s) introduced to coreboot found
with Coverity Scan.
3 new defect(s) introduced to coreboot found with Coverity Scan.
18 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 1397064: (UNINIT)
/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c: 495 in find_gating_window()
/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c: 501 in find_gating_window()
________________________________________________________________________________________________________
*** CID 1397064: (UNINIT)
/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c: 495 in find_gating_window()
489 dramc_dbg("[Byte %d]First pass (%d, %d, %d)\n",
490 dqs, dly_coarse_large,
491 dly_coarse_0p5t, *dly_fine_xt);
492 }
493
494 if (pass_begin[dqs] == 1)
>>> CID 1397064: (UNINIT)
>>> Using uninitialized value "pass_count_1[dqs]".
495 pass_count_1[dqs]++;
496
497 if (pass_begin[dqs] == 1 &&
498 pass_count_1[dqs] * DQS_GW_FINE_STEP >
DQS_GW_FINE_END)
499 dqs_high[dqs] = 0;
500
/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c: 501 in find_gating_window()
495 pass_count_1[dqs]++;
496
497 if (pass_begin[dqs] == 1 &&
498 pass_count_1[dqs] * DQS_GW_FINE_STEP >
DQS_GW_FINE_END)
499 dqs_high[dqs] = 0;
500
>>> CID 1397064: (UNINIT)
>>> Using uninitialized value "pass_count_1[0]".
501 if (pass_count_1[0] * DQS_GW_FINE_STEP >
DQS_GW_FINE_END &&
502 pass_count_1[1] * DQS_GW_FINE_STEP >
DQS_GW_FINE_END) {
503 dramc_dbg("All bytes gating window > 1
coarse_tune,"
504 " Early break\n");
505 *dly_fine_xt = DQS_GW_FINE_END;
506 *coarse_tune = GATING_END;
** CID 1397063: Control flow issues (MISSING_BREAK)
/src/mainboard/google/poppy/variants/nami/mainboard.c: 244 in
variant_devtree_update()
________________________________________________________________________________________________________
*** CID 1397063: Control flow issues (MISSING_BREAK)
/src/mainboard/google/poppy/variants/nami/mainboard.c: 244 in
variant_devtree_update()
238 case SKU_1_SYNDRA:
239 case SKU_2_SYNDRA:
240 case SKU_3_SYNDRA:
241 case SKU_4_SYNDRA:
242 case SKU_5_SYNDRA:
243 case SKU_6_SYNDRA:
>>> CID 1397063: Control flow issues (MISSING_BREAK)
>>> The case for value "441440U" is not terminated by a 'break' statement.
244 case SKU_7_SYNDRA:
245 pl2_id = PL2_ID_SONA_SYNDRA;
246 case SKU_0_VAYNE:
247 case SKU_1_VAYNE:
248 case SKU_2_VAYNE:
249 case SKU_0_PANTHEON:
** CID 1362515: Memory - corruptions (STRING_SIZE)
________________________________________________________________________________________________________
*** CID 1362515: Memory - corruptions (STRING_SIZE)
/util/kconfig/conf.c: 606 in main()
600 case alldefconfig:
601 case randconfig:
602 name = getenv("KCONFIG_ALLCONFIG");
603 if (!name)
604 break;
605 if ((strcmp(name, "") != 0) && (strcmp(name, "1") !=
0)) {
>>> CID 1362515: Memory - corruptions (STRING_SIZE)
>>> Passing string "name" of unknown size to "conf_read_simple", which
>>> expects a string of a particular size.
606 if (conf_read_simple(name, S_DEF_USER)) {
607 fprintf(stderr,
608 _("*** Can't read seed
configuration \"%s\"!\n"),
609 name);
610 exit(1);
611 }
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbLuoVetFLSjdonCi1EjfHRqWGQvojmmkYaBE-2BPJiTQvQ-3D-3D_q4bX76XMySz3BXBlWr5fXXJ4cvAsgEXEqC7dBPM7O5byvtYgJQPCok24hOE-2FkdrOsZAZRSfCtn9ityViZMPj9nSMeNch3UY51nWMYIpwlOA60LzNhIsDN2IglUXd76fmaqU8KSvK6szqbACQ0s2lqVfNY5zCd40gHmRr-2FjOpjZlqhyACfWJYcVX8yz57Q3AelCIBGEuoo1xZ-2Fb5FhRrMJ6Y9eIuKNjltM8Rxy-2B0guJU-3D
--
coreboot mailing list: coreboot@coreboot.org
https://mail.coreboot.org/mailman/listinfo/coreboot
