Hi,
Please find the latest report on new defect(s) introduced to coreboot found
with Coverity Scan.
2 new defect(s) introduced to coreboot found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1399411: Null pointer dereferences (NULL_RETURNS)
/src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c: 90 in
ConfigureDefaultUpdData()
________________________________________________________________________________________________________
*** CID 1399411: Null pointer dereferences (NULL_RETURNS)
/src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c: 90 in
ConfigureDefaultUpdData()
84 {
85 DEVTREE_CONST struct device *dev;
86 DEVTREE_CONST config_t *config;
87 printk(FSP_INFO_LEVEL, "Configure Default UPD Data\n");
88
89 dev = pcidev_path_on_root(SOC_DEV_FUNC);
>>> CID 1399411: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a null pointer "dev".
90 config = dev->chip_info;
91
92 /* Set up default verb tables - Just HDMI audio */
93 UpdData->AzaliaConfigPtr = (UINT32)&mAzaliaConfig;
94
95 /* Set SPD addresses */
** CID 1255946: Memory - corruptions (ARRAY_VS_SINGLETON)
/src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c: 177 in
ConfigureDefaultUpdData()
________________________________________________________________________________________________________
*** CID 1255946: Memory - corruptions (ARRAY_VS_SINGLETON)
/src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c: 177 in
ConfigureDefaultUpdData()
171 case MIPI_DEV_FUNC: /* Camera / Image
Signal Processing */
172 if (FspInfo->ImageRevision >=
FSP_GOLD3_REV_ID) {
173 UpdData->ISPEnable =
dev->enabled;
174 } else {
175 /* Gold2 and earlier FSP:
ISPEnable is the field */
176 /* next to PcdGttSize in
UPD_DATA_REGION struct */
>>> CID 1255946: Memory - corruptions (ARRAY_VS_SINGLETON)
>>> Using "&UpdData->PcdGttSize" as an array. This might corrupt or
>>> misinterpret adjacent memory locations.
177
*(&(UpdData->PcdGttSize)+sizeof(UINT8)) = dev->enabled;
178 printk (FSP_INFO_LEVEL,
179 "Baytrail Gold2 or
earlier FSP, adjust ISPEnable offset.\n");
180 }
181 printk(FSP_INFO_LEVEL,
"MIPI/ISP:\t\t%s\n",
182
dev->enabled?"Enabled":"Disabled");
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbLuoVetFLSjdonCi1EjfHRqWGQvojmmkYaBE-2BPJiTQvaU4HClancRgJSp1vcdHRWU-3D_q4bX76XMySz3BXBlWr5fXXJ4cvAsgEXEqC7dBPM7O5YrlKxmu5dmMqAhFEcChrzUG0OUHvvbNPU45h3XG4HkTXzLmk9YMIjer8Du8RJsrvgTqBHVDDiwMQCp6tFVj524W5Kaz22paG5aw-2FKvOuGxh6-2BDsg0EjfHVSh0m-2BRM3tdjmTTcf6w9qFXszHEawgknl8BxUADGrNTb8j67rzdTH3vuL-2FYozKgL-2BEX8otojPesk-3D
_______________________________________________
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-le...@coreboot.org
