On 20.06.19 06:01, Jacob Garber wrote:
> On Wed, Jun 19, 2019 at 08:38:14PM -0700, ron minnich wrote:
>> Given the number of serious problems that lack of braces causes, I
>> like this proposal. It's indicative that both Rust and Go require the
>> {}, for reasons of safety.
>
> There was a famous vulnerability in Apple's SSL code several years ago
> because of lack of braces. clang-format can also reformat old code to have
> mandatory braces if I'm not mistaken.
What will clang-format do if it encounters?
if (foo)
bar();
baz();
a)
if (foo) {
bar();
}
baz();
or b)
if (foo) {
bar();
baz();
}
Will it spit out a warning? If not, this shows how dangerous automatic
formatting can be. Because after the formatter run, it's much less ob-
vious for the reviewer that something is wrong.
Nico
_______________________________________________
coreboot mailing list -- [email protected]
To unsubscribe send an email to [email protected]
