On 20.06.19 18:12, Jacob Garber wrote: > What Ron said, plus if I recall Coverity has a lint for misleading > indentation, so > I don't think there are any current instances of this in the code base. In > fact, > GCC even has -Wmisleading-indentation that was added to -Wall in GCC 6, so we > should currently be ok. That being said, these warnings are only heuristics > (there's > no precise definition of what "misleading" is supposed to be), so I don't > think > they should be relied upon over using braces, which avoids this problem > entirely.
That's all true, but it forces an order of the tools you run. e.g. don't integrate clang-format into your editor because it might hide the problem before the compiler can warn you. Nico _______________________________________________ coreboot mailing list -- [email protected] To unsubscribe send an email to [email protected]
