On Tue, Jul 07, 2009 at 08:44:11AM +0100, Barbie wrote: > Matt just sent this to me, and I think it might be something to be aware > of if you use a CPANPLUS based smnoker... > > ----- Start forwarded message ----- > > Delivery-date: Mon, 06 Jul 2009 21:40:11 +0100 > From: Matt S Trout <[email protected]> > To: Barbie <[email protected]> > Subject: CPAN testers missing make test output > > If they're running CPANPLUS, then I was finding it vanished. Turns out that > the capture code was wrong - > > Index: lib/CPANPLUS/Dist/MM.pm > =================================================================== > --- lib/CPANPLUS/Dist/MM.pm (revision 2642) > +++ lib/CPANPLUS/Dist/MM.pm (working copy) > @@ -680,7 +680,7 @@ > if ( NO_TESTS_DEFINED->( $captured ) ) { > msg( NO_TESTS_DEFINED->( $captured ), 0 ) > } else { > - msg( loc( "MAKE TEST passed: %2", $captured ), $verbose > ); > + msg( loc( "MAKE TEST passed: %1", $captured ), $verbose > ); > } > > $dist->status->test(1); > > against current svn fixes it for me - %2 where only $captured (the fail > version > had $! in there as well, of course) - so maybe that'll help a bit. > > -- > Matt S Trout Catalyst and DBIx::Class consultancy with a clue > Technical Director and a commit bit: > http://shadowcat.co.uk/catalyst/ > Shadowcat Systems Limited > mst (@) shadowcat.co.uk http://shadowcat.co.uk/blog/matt-s-trout/ > > > ----- End forwarded message ----- > > Cheers, > Barbie. > -- > Birmingham Perl Mongers <http://birmingham.pm.org> > Memoirs Of A Roadie <http://barbie.missbarbell.co.uk> > CPAN Testers Blog <http://blog.cpantesters.org> >
Thanks. I've hopefully applied it to the CPANPLUS svn repository ( I got vaguely confused and forgot to git svn rebase, but I think it committed in the end ). I know Jos is planning a 0.88 release in the next few days. Cheers, -- Chris Williams aka BinGOs PGP ID 0x4658671F http://www.gumbynet.org.uk ==========================
pgpdMH5cTHLtl.pgp
Description: PGP signature
