Hi,

On 7 Jul 2009, at 08:29, Chris 'BinGOs' Williams wrote:

On Tue, Jul 07, 2009 at 08:44:11AM +0100, Barbie wrote:
Matt just sent this to me, and I think it might be something to be aware
of if you use a CPANPLUS based smnoker...

----- Start forwarded message -----

Delivery-date: Mon, 06 Jul 2009 21:40:11 +0100
From: Matt S Trout <[email protected]>
To: Barbie <[email protected]>
Subject: CPAN testers missing make test output

If they're running CPANPLUS, then I was finding it vanished. Turns out that
the capture code was wrong -

Index: lib/CPANPLUS/Dist/MM.pm
===================================================================
--- lib/CPANPLUS/Dist/MM.pm     (revision 2642)
+++ lib/CPANPLUS/Dist/MM.pm     (working copy)
@@ -680,7 +680,7 @@
                if ( NO_TESTS_DEFINED->( $captured ) ) {
                    msg( NO_TESTS_DEFINED->( $captured ), 0 )
                } else {
- msg( loc( "MAKE TEST passed: %2", $captured ), $verbose ); + msg( loc( "MAKE TEST passed: %1", $captured ), $verbose );
                }

                $dist->status->test(1);

against current svn fixes it for me - %2 where only $captured (the fail version
had $! in there as well, of course) - so maybe that'll help a bit.

As Chris mentioned, fix in SVN. Not a big deal for CPANPLUS based smokers, as this is the output when make test *passed*, which is not something smokers tend to care about.

Cheers,

--
        Jos Boumans

        'Real programmers use "cat > a.out"'




Reply via email to