On 1/8/2011 2:00 AM, Gabor Szabo wrote:
On Sat, Jan 8, 2011 at 1:38 AM, David Cantrell<da...@cantrell.org.uk> wrote:
If they are simple connection tests, that I would think you should be
fine. Any complex then running under AUTOMATED_TESTING is reasonable,
and prompting (default to No) otherwise.
Perhaps do a simple check for connectivity and have it skip the more
complex tests if that doesn't work. Naturally, you should do the
connectivity test using raw Socket.pm so as not to introduce any
dependencies :-)
I think it would be better to avoid any network activity without the consent
of the person running it. There are places where such activity will trigger
an alarm.
The agreement of the user can be setting AUTOMATED_TESTING or
some other environment variable (e.g. the API key of some web application)
or just answering yes to a question during the installation process.
For me, setting AUTOMATED_TESTING is not agreement
that anything goes for tests. If a module needs to
access the network for testing, it should ask
the user.
E.g., if I test one module that ends up pulling in
another module it has as a dependency, that doesn't
mean that network access is ok or that I have gone
through the entire list of modules being built to
check for network mischief.
I vote for prompt/query the user, default n, with
an environment variable that could be set if the
user wanted network testing by default.
--Chris
