On Sat, Apr 16, 2011 at 11:56:14AM +0200, Johanna Ploog wrote: > Hi guys! > > So I was about to merge galehar's commit for friendly sensed monsters, > when I realized that trunk now has one more monster than 0.8, namely > the holy swine.
They are not going to see any real use at least until holyhaul gets some more steam. The inconsistency it fixes is so unlikely to happen adding the swines was probably more effort than it was worth (ok, ok, a tile and a line of code...). > In the unlikely case that a save with a holy swine is transferred to 0.8, > what happens? Crash? Hmm, right, yes. We might add AXED_MON(MONS_HOLY_SWINE) to mon-data.h, but then, you would need to try really hard to get one to be present in a game. And then, you'd have to transfer the save. > Now if I add the friendly sensed monster, that would mean that on transfer > any holy swine is changed to a friendly monster placeholder, which > probably also breaks stuff. Just reserve the enum and all will be fine. > I'm also not sure how the game handles remembered monsters that don't > exist in the current version. There will be a assertion crash. > To cut a long story short, do we need to handle this somehow? I wouldn't really care. On the other hand, it's an one-line fix so it costs us a single commit. [correction: just pick 49bd2585, on branch "for-0.8"] > The 0.8 wiki page mentions the "unarmed auxilary special damage" as > something that might need rolling back, but I couldn't even work out > what's meant by it, let alone which commits belong to it. It's about claws causing bleeding. The effect is pretty marginal, and causes about no damage. > As I haven't actually played any real games, I've no idea how noticeable > the changes are, or whether rolling back is even necessary. It can at most very slightly confuse players. I personally wouldn't care. > I've already announced this on IRC, but I'm going to leave the team > tomorrow because I start a job on Monday that has a no-competition-clause, > which does include unpaid game development. For me it's the end of an > era, and for you it means you'll need a new release manager. The > developers currently most active are Adam, Chris and Raphael, so it'll > probably have to be one of you. I'd nominate Adam Are you aware that Lord High Cherry-picker is a position of responsibility? That's not my strong side... I'm not opposing being nominated a volunteer, but if anyone else wants the position, say so. > unicode changes, which is the main area of commits that haven't been > cherrypicked Most of the changes have quite little effect right now: mostly, if a line gets wrapped right on a non-ASCII char, it will be show as corruption at the end of one line and the start of the next one. And these can happen only in file paths (unlikely to be long) and character notes (unlikely that people can notice they can use non-ASCII there). Since there's a number of entangled commits, I'd ignore that for 0.8. What matters is that freetype font problem, since a player already ran into it. I've put the fix for that (3 commits) on a branch "for-0.8". > As far as I can tell, there aren't actually any 0.8 pre-release > versions available to the players right now, but I think that getting > feedback is mandatory. Napking took care of it. There are no Mac builds of 0.8, though, and this is a heavily undertested area. -- 1KB // Microsoft corollary to Hanlon's razor: // Never attribute to stupidity what can be // adequately explained by malice. ------------------------------------------------------------------------------ Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev _______________________________________________ Crawl-ref-discuss mailing list Crawl-ref-discuss@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/crawl-ref-discuss