On 01/07/2016 07:40 PM, David M Williams wrote:
[email protected] wrote on 01/07/2016
12:30:21 PM:
> From: Mickael Istria <[email protected]>
> To: [email protected],
> Date: 01/07/2016 12:30 PM
> Subject: Re: [cross-project-issues-dev] Enforce Gerrit for Simrel?
> Sent by: [email protected]
>
> ...
> Good. I wasn't aware of that. That's a major step forward.
> However a quick lookup on b3aggrcon files shows that many (probably
> the majority) of contributions seems to ignore that rule; as they
> either don't specify a versionRange or specify a versionRange in a
> [a.b.c,x.y.z] way.
>
Yep. You have stated your desire to "test for that" ... so have at it.
(But, do read the "rule" carefully ... it is an either/or type. One
condition is easy to test for with simply the text input. The other
would have to look at the source repository and make sure it was a
'simple' repository (not a composite).
Would a contribution that adds/sets the fully qualified version to all
current b3aggrcon files missing it be welcome? Projects contributing
volatile content fail the build next time they update their contributed
repo, so we'll know which projects need to be educated to this new rule
(there's already one contributed by me that's now an outlaw ;) ).
Once we have a good basis, I'll make an addition validation job that
checks that this rule on all incoming Gerrit contributions.
--
Mickael Istria
Eclipse developer at JBoss, by Red Hat <http://www.jboss.org/tools>
My blog <http://mickaelistria.wordpress.com> - My Tweets
<http://twitter.com/mickaelistria>
_______________________________________________
cross-project-issues-dev mailing list
[email protected]
To change your delivery options, retrieve your password, or unsubscribe from
this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
