Tony, I just have one comment:
In file usr/src/lib/pkcs11/libpkcs11/common/pkcs11Slottable.c You're checking last_pol_mechs before initializing it. Although it's rare something would go wrong (a match on a garbage pointer), I think it should be set. That is, change: 169 CK_MECHANISM_TYPE_PTR last_pol_mechs; To: 169 CK_MECHANISM_TYPE_PTR last_pol_mechs = NULL; Around line 211 I would also add a comment explaining what you're doing (checking to avoid a double free), as it's not obvious. - Dan -- This message posted from opensolaris.org
