On 03/16/09 21:56, Anthony Scarpino wrote:
> Ferenc Rakoczi wrote:
>> Hi, Tony,
>>
>> pkcs11Slottable.c
>>
>> I would prefer another method to avoid the double free here (e.g. a
>> reference counter), but even if we stick with this method, a comment
>> about why it should work is in order. Also, doesn't lint complain about
>> the uninitialized use of last_pol_mechs in line 212?
>
> I know there are dozens of ways to fix it..  I even commented about 
> that in the bug  :) .. This function is only called when the process 
> is ending, so there is little need for any detailed methods for 
> fixing..  I just choose the simplest one..

 There is an even simpler fix and it is cleaner -

 Just move lines 213-215 to be after line 210 (line numbers in old code).

-Krishna

Reply via email to